Skip to content

ui: fix advance setting behaviour in autoscale form#11306

Merged
sureshanaparti merged 1 commit intoapache:4.19from
shapeblue:ui-autoscaleformfix
Jul 30, 2025
Merged

ui: fix advance setting behaviour in autoscale form#11306
sureshanaparti merged 1 commit intoapache:4.19from
shapeblue:ui-autoscaleformfix

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Jul 28, 2025

Description

Fixes #11269

The current dysfunctional behaviour was introduced in #6571. In advanced settings interface for ssh keypairs, userdata, affinity group, etc are show but the toggle to show/hide them was not working correctly.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
ui: fix advance setting behaviour in autoscale form
b09ff40 
Fixes apache#11269

The current dysfunctional behaviour was introduced in apache#6571. In advanced
settings interface for ssh keypairs, userdata, affinity group, etc are
show but the toggle to show/hide them was not working correctly.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

shwstppr commented Jul 28, 2025

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 28, 2025

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@shwstppr shwstppr linked an issue Jul 28, 2025 that may be closed by this pull request
autoscaling UI issue #11269
Closed
@codecov
Copy link

codecov bot commented Jul 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.17%. Comparing base (ca6d2dc) to head (b09ff40).
⚠️ Report is 3 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19   #11306      +/-   ##
============================================
- Coverage     15.17%   15.17%   -0.01%     
  Complexity    11362    11362              
============================================
  Files          5415     5415              
  Lines        476030   476030              
  Branches      58115    58115              
============================================
- Hits          72246    72243       -3     
- Misses       395701   395703       +2     
- Partials       8083     8084       +1
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.90% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

blueorangutan commented Jul 28, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11306 (QA-JID-692)

@shwstppr shwstppr marked this pull request as ready for review July 28, 2025 12:29
Copilot AI reviewed Jul 30, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the autoscale form's advanced settings toggle behavior. The advanced settings interface for SSH keypairs, userdata, and affinity groups was not properly showing/hiding when the toggle was activated.

Key Changes

  • Replaced v-show directive with v-if directive for the advanced settings container

@sureshanaparti
Copy link
Contributor

sureshanaparti commented Jul 30, 2025

able to reproduce with qa simulator env, and verified with pr's simulator env.

@sureshanaparti sureshanaparti merged commit fd42232 into apache:4.19 Jul 30, 2025
25 checks passed
@sureshanaparti sureshanaparti mentioned this pull request Jul 30, 2025
Closed
@DaanHoogland DaanHoogland deleted the ui-autoscaleformfix branch July 30, 2025 06:09
@DaanHoogland DaanHoogland added this to the 4.19.4 milestone Jul 30, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 6, 2025
@shwstppr @dhslove
ui: fix advance setting behaviour in autoscale form (apache#11306)
5e2d055 
Fixes apache#11269

The current dysfunctional behaviour was introduced in apache#6571. In advanced
settings interface for ssh keypairs, userdata, affinity group, etc are
show but the toggle to show/hide them was not working correctly.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@vishesh92 vishesh92 Awaiting requested review from vishesh92

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.19.4

Development

Successfully merging this pull request may close these issues.

autoscaling UI issue

5 participants

@shwstppr @blueorangutan @sureshanaparti @DaanHoogland